Skip to Content

Typos, Remarks and Questions

Posted in

Hi,

I think, I have spotted some typos in "Home » Reference » PDE related tasks & macros":

  • buildPlugin
    Some attributes are missing in the documentation.
  • buildFeature
    "The buildPlugin task provides the following arguments:" -> "The buildFeature task provides the following arguments:"
  • buildFeature
    The Required field says: "Either projectName or featureId (and optional featureVersion) has to be set".
    Could it be, that it is necessary to provide the featureVersion, if one uses the featureId?
  • buildFeature
    Some attributes are missing in the documentation.
  • buildProduct
    "The buildPlugin task provides the following arguments:" -> "The buildProduct task provides the following arguments:"
  • buildProduct
    Some attributes are missing in the documentation.
  • executeProduct
    In the example: The line "

    " occurs twice.
    The last should probably be: "

    "

The "commandline" attribute in the buildProduct macro does not work as expected. Set to "false" delivers
an exe for commandline and gui, "true" delivers only the commandline. That is probably wrong in two ways?

A question to the "packageAsJar" attribute in the buildProduct macro: If the attribute is set to true, one gets
a jar-File in the features dir which includes the plugin.xml (feature based product definition).
Is this intended? Eclipse is not doing this during a product export.

Do you plan to introduce the a4e PDE build at http://germany.osgiusers.org/Main/WorkshopBuildingOSGiApplication?

Hopefully you are not annoyed by my comments, regards
Georg

You are welcome ;-)

Hi Georg,

thanks for your feedback, I fixed the typos and added the missing attributes to the documentation.

Kasimir will answer the product related questions later (I hope he will ;-))

And yes: we plan to intorduce the a4e PDE build at the german user group meeting (btw I have to send my abstract to Jochen...)

Regards,
Gerd

A kind reminder for answers to questions of my previous post

Hi,

if possible, please answer the two questions from my previous post (addressed to the M1 release):

  • The "commandline" attribute in the buildProduct macro does not work as expected. Set to "false" delivers
    an exe for commandline and gui, "true" delivers only the commandline. That is probably wrong in two ways?
  • A question to the "packageAsJar" attribute in the buildProduct macro: If the attribute is set to true, one gets a jar-File in the features dir which includes the plugin.xml (feature based product definition).
    Is this intended? Eclipse is not doing this during a product export.

    Till now I have not checked, if the behavior changed in the M2 release.

    Thanks for your help, kind regards,
    Georg

  • Regarding the commandline

    Regarding the commandline attribute: It behaves as described in the reference. If it's set to 'false' the gui as well as the commandline starter are being copied whereas the value 'true' only copies the commandline version. For linux this distinction is not necessary.

    Regarding the "packageAsJar" attribute: It's just a matter of creating exploded plugins or not. You can enable this in eclipse, too. This difference has no effect on the resulting build as an exploded version is technically an equivalent of a jar version.

    Best regards

    Daniel Kasmeroglu

    Re: Regarding the commandline

    Hi,

    thank you for the answer.

    Yes, it behaves the way you described it in your post.
    From the description in the reference

    commandline: If set to true the commandline version of the rcp will be built. This is only relevant for win32 builds.

    I would expect the following:
    1. Always generate "eclipse.exe". That is what eclipse is doing during a product export.
    2. If commandline is set to true, I would expect to get the commanline version "eclipsec.exe" in addition.

    Seems that we have a different view at this topic.

    Best regards,
    Georg.

    If commandline is set to true

    If commandline is set to true the rcp is only a commandline application, so it wouldn't need a 'eclipse.exe'.
    Let's say your product is called 'fred' which would result in the following executables:

    commandline = false

    fred.exe - copied from eclipse.exe
    fredc.exe - copied from eclipsec.exe

    commandline = true

    fred.exe - copied from eclipsec.exe

    I will modify the documentation about this, so people won't be "confused" about it.

    Best regards

    Daniel Kasmeroglu