Skip to Content

buildFeature macro in a4e-pde-macros.xml has probaly some typos

Posted in

Hi,

I'am playing with the PDE stuff. Unfortunately there are no examples for a feature and a product build. It would be nice to have some.
Could it be that all occurences of "executeProduct" in the buildFeature macro in a4e-pde-macros.xml have to be replaced with "executeFeature"?

Regards
Georg

Works fine for me...

Hi Georg,

the buildFeature works fine for me. Currently I'm working on some tutorials on how to use the different tasks/macros, I hope I will finish it in the next 4-5 days...

Building a feature should be easy - just call the 'buildFeature' macro:

<buildFeature workspaceDirectory="${workspaceDirectory}"
              projectName="org.javakontor.sherlog.feature"
              targetplatformid="target.platform"
              destination="${destination.directory}" /> 

And I can't find any occurences of 'executeProduct' in the buildFeature macro!? Can you send an example snippet?

Regards,
Gerd

snippet

Hi,

thank you for the fast answer. Here is the snippet:

  <!-- =================================
          target      : buildFeature
          description : Builds an eclipse feature project. Each contained plug-in project will be build.
         ================================= -->
 
   ...
 
        <!-- Step 3: Build the plug-ins  -->
        <!-- Step 3.1: Build the plug-ins  -->
        <ant4eclipse:forEachPlugin filter="(executeProduct.plugin.isSource=true)">
          <echo>Building plug-in project '${executeFeature.plugin.filename} (${executeFeature.plugin.id}_${executeFeature.plugin.resolvedversion})' </echo>

I downloded the M1.zip file. The first occurence of "executeProduct" is in Step 3.1. After I changed it, it seems to work.

Concerning the product build, it seems that no config.ini is automatically build in the configuration dir. Is this your intention?

Regards,
Georg

Typo has been gone

The typo you've mentioned has already been gone shortly after the M1 release, so it's definitely fixed for M2.

The config.ini is not generated by default as that wasn't needed 'til now as it wasn't of interest for us. Since implementing this should be no biggy I opened an issue for that:

http://www.javakontor.org:8080/jira/browse/AE-175

Please note that I've targeted it for M3 since I don't know if I find the time to fix it for M2 (the date is coming closer).

I'm currently at work so I

I'm currently at work so I can't verify your problem just by "memorization". If 'executeProduct....' is used within the 'buildFeature' macro I can clearly say that this is wrong. Nevertheless it surprises me that such a fault slipped through.

Regarding the config.ini I will give you an answer later as I'm currently unsure about whether I've added such a default generation step or not.

There are still some typos in the M2 release

Please check the following lines in "a4e-pde-macros.xml":

Line: 771

filter="(executeProduct.feature.isSource=true)"

should probably be
filter="(executeFeature.feature.isSource=true)"



Line: 807
filter="(executeProduct.feature.isSource=false)

should probably be
filter="(executeFeature.feature.isSource=false)"

Regards
Georg

These typos also already have

These typos also already have been gone, too. Unfortunately the M2 has been created two revisions earlier, so they will be fixed with the upcoming M3.